refactor: Move cURL converter to frontend #11432
Open
+2,499
−1,232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
…onverter-to-frontend
|
Linking the PR that helps to fix this. curlconverter/curlconverter#704 We're still waiting on the release for this though. |
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
netroy
previously approved these changes
Feb 5, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
PAY-1681-move-curlconverter-to-frontend
|
| Run status |
|
| Run duration | 04m 32s |
| Commit |
|
| Committer | Csaba Tuncsik |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
434
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
…onverter-to-frontend
netroy
previously approved these changes
Feb 6, 2025
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
Feb 7, 2025
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
curlconverterdropped CJS support a while ago, so we can't upgrade it on the backend.To be able to use the newer ESM versions of this package, we have migrated this entire functionality into the frontend, where we support ESM dependencies.
Note: This PR contains a large pnpm-patch to include some changes that we made to
curlconvereter, and we'll remove this patch once our changes are published in the next version of that package.Related Linear tickets, Github issues, and Community forum posts
PAY-1681
Fixes #9768
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)