Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Load only personal credentials when setting up a template #12826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Jan 24, 2025

Summary

Templates are created in Personal by default, so we only need to show personal credentials in the setup dialog.

NOTE: For now, the CredentialPicker component is only used in the template setup so this quick fix makes sense. Once we decide to reuse it it will make sense to pass project/owner as a prop so we can do custom filtering.

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-2984

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 24, 2025
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 27, 2025

n8n    Run #8971

Run Properties:  status check failed Failed #8971  •  git commit 5a982c100d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-2984-setup-template-credentials-list-fix
Run status status check failed Failed #8971
Run duration 06m 17s
Commit git commit 5a982c100d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 30
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 3
Tests that passed  Passing 263
View all changes introduced in this branch ↗︎

Tests for review

Failed  5-ndv.cy.ts • 1 failed test

View Output Video

Test Artifacts
NDV > can link and unlink run selectors between input and output Test Replay Screenshots Video
Failed  12-canvas.cy.ts • 5 failed tests

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should rename node (context menu or shortcut) Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > should not allow empty strings for node names Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > should render connections correctly if unkown nodes are present Test Replay Screenshots Video
Canvas Node Manipulation and Navigation > Canvas Zoom Functionality > should zoom using scroll or pinch gesture Test Replay Screenshots Video
Failed  12-canvas-actions.cy.ts • 7 failed tests

View Output Video

Test Artifacts
Canvas Actions > should render canvas Test Replay Screenshots Video
Canvas Actions > should connect and disconnect a simple node Test Replay Screenshots Video
Canvas Actions > should add a node via plus endpoint drag Test Replay Screenshots Video
Canvas Actions > should add disconnected node if nothing is selected Test Replay Screenshots Video
Canvas Actions > should delete a connection by moving it away from endpoint Test Replay Screenshots Video
Canvas Actions > should not break lasso selection when dragging node action buttons Test Replay Screenshots Video
Canvas Actions > should not break lasso selection with multiple clicks on node action buttons Test Replay Screenshots Video
Failed  30-langchain.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Langchain Integration > should disable test workflow button Test Replay Screenshots Video
Langchain Integration > should render runItems for sub-nodes and allow switching between them Test Replay Screenshots Video
Langchain Integration > should execute up to Node 1 when using partial execution Test Replay Screenshots Video
Failed  10-undo-redo.cy.ts • 5 failed tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding node in the middle Test Replay Screenshots Video
Undo/Redo > should undo/redo moving nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo deleting a connection by moving it away Test Replay Screenshots Video
Undo/Redo > should undo/redo renaming node using keyboard shortcut Test Replay Screenshots Video
Undo/Redo > should undo/redo multiple steps Test Replay Screenshots Video

The first 5 failed specs are shown, see all 59 specs in Cypress Cloud.

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants