feat(n8n AWS SNS Node): Add option to send message directly to phone number #12870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TheZoker
changed the title
TheZoker
commented
Jan 27, 2025
| @@ -159,9 +185,24 @@ export class AwsSns implements INodeType { | |||
| displayOptions: { | |||
| show: { | |||
| operation: ['publish', 'delete'], | |||
| target: ['topic'], | |||
There was a problem hiding this comment.
I'm not 100% sure, how to set this logic.
I want the field to display if:
- operation == 'delete'
- operation == 'publish' && 'target == 'topic'
How can this be done? Thanks!
n8n-assistant
bot
added
community
|
Hey @TheZoker, Thanks for the PR, We have created "GHC-636" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new option, to send a message directly to a phone number via AWS SNS.
This function is described in the AWS docs:
https://docs.aws.amazon.com/sns/latest/dg/sms_sending-overview.html#sms_publish-to-phone
Related Linear tickets, Github issues, and Community forum posts
This solves my own request/question in the community:
https://community.n8n.io/t/how-to-send-an-sms-with-aws-sns/73028
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)