feat(Kafka nodes): Client side SSL authentication support for Kafka nodes #12914
+98
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related fields to mask input data. - Remove the `rows: 4` previously set as the fields are now forced to be one row height. - Remove the `placeholder` property be cause it is less readable now that the fields are one row height.
|
cyla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
n8n-assistant
bot
added
community
|
Hey @cylabr, Thanks for the PR, We have created "GHC-653" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
|
Thanks @Joffcom , I'd like to say that having SSL support is critical for enterprise level applications such as us at Numberly. Hope this gets in soon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds client side SSL authentication support for Kafka nodes, to be able to connect to a Kakfa cluster that enforces a client side SSL authentication.
New properties are available in the Kafka credentials form to achieve that:
Related Linear tickets, Github issues, and Community forum posts
A previous PR covering this subject was closed and never merged, this new PR removes the ability to specify a CA certificate to avoid any confusion.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)