Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenAI Chat Model Node): Add reasoning effort option to control the amount of reasoning tokens to use #13103

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

jeanpaul
Copy link
Contributor

@jeanpaul jeanpaul commented Feb 6, 2025

Summary

The o1 and o3 models support a new reasoning_effort parameter that controls how many reasoning tokens to use. This change implements that in the OpenAI Chat Model Node.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...chain/nodes/llms/LMChatOpenAi/LmChatOpenAi.node.ts 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 6, 2025

n8n    Run #9173

Run Properties:  status check passed Passed #9173  •  git commit dfe0577d2e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 jeanpaul 🗃️ e2e/*
Project n8n
Branch Review implement-reasoning-effort-o3
Run status status check passed Passed #9173
Run duration 04m 42s
Commit git commit dfe0577d2e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 jeanpaul 🗃️ e2e/*
Committer JP van Oosten
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 434
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ All Cypress E2E specs passed

@jeanpaul jeanpaul merged commit 76e0c99 into master Feb 6, 2025
37 checks passed
@jeanpaul jeanpaul deleted the implement-reasoning-effort-o3 branch February 6, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants