Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hive multi org #4490

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

The hive multi org #4490

wants to merge 3 commits into from

Conversation

minhkhuong1204
Copy link

@minhkhuong1204 minhkhuong1204 commented Nov 1, 2022 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Joffcom
Copy link
Member

Joffcom commented Nov 2, 2022

Hey @minhkhuong1204,

I like the idea but is adding the organisation as a required field not a breaking change? Would it maybe be better as an additional parameter that is optional? That way anyone currently using the node won't be in for a surprise if they upgrade.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Nov 2, 2022
@minhkhuong1204
Copy link
Author

Hey @minhkhuong1204,

I like the idea but is adding the organisation as a required field not a breaking change? Would it maybe be better as an additional parameter that is optional? That way anyone currently using the node won't be in for a surprise if they upgrade.

Hi @Joffcomm,
Okay, I will change it to optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minhkhuong1204 @CLAassistant @Joffcom