API to list credentials #4854
Open
API to list credentials #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is a first attempt
- All credentials are listed, when they should be filtered
- Need to add an extra assertionto make sure no extra properties are
returned
|
|
n8n-assistant
bot
added
community
|
This PR is now working for members and is ready to be merged. |
|
I notice the Enterprise Edition supports sharing of credentials between users. I also notice the Public API doesn't have any references to the EE at all, so I haven't supported shared credentials via |
|
Hi - please can someone from n8n take a look at this PR? |
|
Adding the internal ticket id for the review... |
Joffcom
added
the
in linear
|
@johncant Sorry for such a long delay. Do you still need this endpoint? |
|
Yes please! |
|
Given that it's taken a year and a half for anyone to even look at this pull request, I hope you understand if I don't take the time to update it. I cannot be sure that this is a good use of my time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm hoping to add a
GET /credentialsendpoint to the public API. My use case for this is populating a dropdown box in a 3rd party app that needs to create workflows that use credentials. I don't see any advantage in returningdatavia the public API that outweighs any security considerations, so this isn't returned.nodesAccessalso isn't returned.Link to feature request: https://community.n8n.io/t/n8n-api-add-functions-for-credentials/18522 . Luckily I had some free time, so I started implementing it.
Please can you take a look at my first attempt and let me know what you think?
It isn't fully ready and shouldn't yet be merged - specifically, all credentials are returned, regardless of whether the user is anIt's ready.ownerormember.Thanks a lot,
John