fix: 💚 better build

nabla-studio · Oct 26, 2024 · feeb819 · feeb819
1 parent 720816e
commit feeb819
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/.github/workflows/release-preview.yml b/.github/workflows/release-preview.yml
@@ -68,7 +68,11 @@ jobs:
       - name: Run Nx release version
         run: pnpm release -d false
 
-      # Step 10: Run publish
+      # Step 10: Run the build for the affected changes
+      - name: Run build
+        run: pnpm build
+
+      # Step 11: Run publish
       - name: Publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
@@ -78,12 +82,12 @@ jobs:
         # which is set up by `setup-node` action.
         run: npx nx release publish --verbose --tag $RELEASE_TAG
 
-      # Step 11: Upload artifacts
+      # Step 12: Upload artifacts
       - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
           path: './dist'
 
-      # Step 12: Clean up dist directory
+      # Step 13: Clean up dist directory
       - name: Cleanup dist directory
         run: rm -rf ./dist # Remove the dist directory to start fresh
diff --git a/.github/workflows/release-production.yml b/.github/workflows/release-production.yml
@@ -66,7 +66,11 @@ jobs:
       - name: Run Nx release version
         run: pnpm release -d false
 
-      # Step 10: Run publish
+      # Step 10: Run the build for the affected changes
+      - name: Run build
+        run: pnpm build
+
+      # Step 11: Run publish
       - name: Publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
@@ -76,12 +80,12 @@ jobs:
         # which is set up by `setup-node` action.
         run: pnpx nx release publish --verbose
 
-      # Step 11: Upload artifacts
+      # Step 12: Upload artifacts
       - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
           path: './dist'
 
-      # Step 12: Clean up dist directory
+      # Step 13: Clean up dist directory
       - name: Cleanup dist directory
         run: rm -rf ./dist # Remove the dist directory to start fresh
diff --git a/nx.json b/nx.json
@@ -78,11 +78,10 @@
     "projects": ["*", "!nextjs", "!vue3"],
     "projectsRelationship": "independent",
     "version": {
+      "conventionalCommits": true,
       "generatorOptions": {
         "packageRoot": "dist/packages/{projectName}",
-        "currentVersionResolver": "git-tag",
-        "specifierSource": "conventional-commits",
-        "fallbackCurrentVersionResolver": "disk"
+        "updateDependents": "auto"
       }
     },
     "changelog": {