Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: add some log for naming selectInstances #681

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

robynron
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79bf755) 29.54% compared to head (994714f) 29.69%.

❗ Current head 994714f differs from pull request most recent head c271f94. Consider uploading reports for the commit c271f94 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   29.54%   29.69%   +0.15%     
==========================================
  Files          40       40              
  Lines        3121     3122       +1     
==========================================
+ Hits          922      927       +5     
+ Misses       2131     2128       -3     
+ Partials       68       67       -1     
Files Coverage Δ
clients/naming_client/naming_client.go 34.65% <100.00%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KomachiSion KomachiSion merged commit 03026b7 into nacos-group:master Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants