nacos-go-sdk support grpc tls #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin0325
reviewed
Apr 17, 2024
| logger.Infof(" tls config from env is not enable") | ||
| return | ||
| } | ||
| trustAll, err := strconv.ParseBool(os.Getenv("nacos_remote_client_rpc_tls_trustAll")) |
There was a problem hiding this comment.
所有TLS相关的信息应该在用户创建client时就设置好，不应该再从环境变量中获取吧
There was a problem hiding this comment.
如果用户没有通过代码指定，可以通过环境变量设置，和java版本保持一致
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.