Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use modern NodeJS code #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

favna
Copy link

@favna favna commented Sep 25, 2024

The NodeJS script was build for old NodeJS versions. In the current day and age we can write a lot cleaner code. The new script targets NodeJS v18 and above.

Notable differences:

  • ESM for top level await and import syntax
  • node: imports
  • Node's native promise based API for fs and setTimeout
  • File URLs over path joining
  • Optional chaining
  • Object.values and for...of looping instead of for...in looping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants