-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Bar because why not? (py) #27
Open
JuvenileLad
wants to merge
1
commit into
nadimkobeissi:main
Choose a base branch
from
JuvenileLad:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,24 +4,28 @@ | |
import time | ||
import aiohttp | ||
import asyncio | ||
from tqdm import tqdm | ||
from urllib.parse import urlparse | ||
|
||
url = 'https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s' | ||
|
||
async def delay(ms): | ||
await asyncio.sleep(ms / 1000) | ||
|
||
async def download_image(session, image_url, file_path): | ||
async def download_image(session, image_url, file_path, error_log): | ||
try: | ||
async with session.get(image_url) as response: | ||
if response.status != 200: | ||
raise Exception(f"Failed to download image: {response.status}") | ||
raise Exception(f"Error code: {response.status}") | ||
content = await response.read() | ||
with open(file_path, 'wb') as f: | ||
f.write(content) | ||
except Exception as e: | ||
print(f"Error downloading image: {str(e)}") | ||
error_log.append(f"Error downloading image {image_url}[{str(e)}]") | ||
|
||
async def main(): | ||
error_log = [] | ||
|
||
try: | ||
async with aiohttp.ClientSession() as session: | ||
async with session.get(url) as response: | ||
|
@@ -39,24 +43,35 @@ async def main(): | |
print(f"📁 Created directory: {download_dir}") | ||
|
||
file_index = 1 | ||
for key, subproperty in data.items(): | ||
if subproperty and subproperty.get('dhd'): | ||
image_url = subproperty['dhd'] | ||
print(f"🔍 Found image URL!") | ||
parsed_url = urlparse(image_url) | ||
ext = os.path.splitext(parsed_url.path)[-1] or '.jpg' | ||
filename = f"{file_index}{ext}" | ||
file_path = os.path.join(download_dir, filename) | ||
total_images = len([key for key, subproperty in data.items() if subproperty.get('dhd')]) | ||
|
||
await download_image(session, image_url, file_path) | ||
print(f"🖼️ Saved image to {file_path}") | ||
# initialize progress bar with the total number of images | ||
with tqdm(total=total_images, desc="Downloading", unit="image", colour="red") as pbar: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great addition |
||
for key, subproperty in data.items(): | ||
if subproperty and subproperty.get('dhd'): | ||
image_url = subproperty['dhd'] | ||
parsed_url = urlparse(image_url) | ||
ext = os.path.splitext(parsed_url.path)[-1] or '.jpg' | ||
filename = f"{file_index}{ext}" | ||
file_path = os.path.join(download_dir, filename) | ||
await download_image(session, image_url, file_path, error_log) | ||
|
||
file_index += 1 | ||
await delay(250) | ||
pbar.update(1) | ||
file_index += 1 | ||
|
||
await delay(250) | ||
|
||
except Exception as e: | ||
print(f"Error: {str(e)}") | ||
|
||
# After all downloads, report any errors that occurred | ||
if error_log: | ||
print("\n⚠️ The following errors occurred during downloads:") | ||
for error in error_log: | ||
print(error) | ||
else: | ||
print("\n✅ All images downloaded successfully!") | ||
|
||
def ascii_art(): | ||
print(""" | ||
/$$ /$$ /$$ /$$ /$$$$$$$ /$$$$$$ /$$$$$$$ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably also need to add a step here
mkbsd/README.md
Line 28 in 82e50c6
tqdm
viapip install tqdm