return when file io is EOF #311
Conversation
| buf = '' | ||
| rest = sz | ||
| while rest > 0 | ||
| n = io.read([rest, @chunk_size].min, buf) | ||
| raise ArgumentError.new("Illegal size value: #size returns #{sz} but cannot read") if n.nil? |
There was a problem hiding this comment.
Yes, it's intentional to detect the situation where "it should be able to read XX bytes but httpclient can read only <XX bytes". I didn't want to ignore this unexpected situation.
How does sz become unexpected number in your case?
There was a problem hiding this comment.
This phenomenon occurred when I was testing with webmock.
I seem that the same proccessing is performed twice in a testing.
Maybe, around here file.
https://github.com/bblimke/webmock/blob/master/lib/webmock/http_lib_adapters/httpclient_adapter.rb
I think that there may be a problem with the webmock side possibly. I try to search.
Thanks.
There was a problem hiding this comment.
In build_request_signature, I seem that a file pointer is not reset.
Error occured when FILE IO's postion is END.
I don't want to error as possible.