Report error rather than panicking with unreachable!

[gibbz00]

The title should be somewhat self-explanatory. Had a project of my crash when reaching the previous unreachable! without any explanation in the error. Turns out the error message was "The operation is insecure.", which is not necessarily a bug of itself: https://stackoverflow.com/questions/11768221/firefox-websocket-security-issue/12042843#12042843

[najamelan]

hi, thanks for reporting. Sorry I didn't see your message before. I will look into it tomorrow.

[gibbz00]

No worries!

[najamelan]

This is quite crazy because MDN explicitly states this can only throw one exception:
https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket

Is there an easy way to reproduce the error you saw? Which browser was it on?

[najamelan]

So I setup an https server locally. Connected to ws protocol (eg, server without ssl). I have network.websocket.allowInsecureFromHTTPS set to false in Firefox, yet the websocket just works, so it seems I can't repro this:

[najamelan]

The code I used was very simple:

use ws_stream_wasm::*;
use wasm_bindgen::UnwrapThrowExt;

const URL: &str = "ws://localhost:3212/";

fn main()
{
	let program = async
	{
		let (ws, wsio) = WsMeta::connect( URL, None ).await.expect_throw( "Could not create websocket" );

		assert_eq!( WsState::Open, ws  .ready_state() );
		assert_eq!( WsState::Open, wsio.ready_state() );

		ws.wrapped().close().expect_throw( "close WebSocket" );

		assert_eq!( WsState::Closing, ws  .ready_state() );
		assert_eq!( WsState::Closing, wsio.ready_state() );

		ws.close().await.expect_throw( "close ws" );

		assert_eq!( WsState::Closed, ws  .ready_state() );
		assert_eq!( WsState::Closed, wsio.ready_state() );
	};

	wasm_bindgen_futures::spawn_local(program);
}

[gibbz00]

Hi again,

Yes, I was also using Firefox. The error happened only when the WS signalling server wasn't hosted locally. Do you want me to prepare an example for you?

[najamelan]

If there is any way I can reproduce, that would be great. That way I can have a closer look at the error.