Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n drop unto timeline #630

Closed
wants to merge 7 commits into from

Conversation

prh7
Copy link

@prh7 prh7 commented Aug 2, 2019

Issue Number

Link to issue this PR addresses. If no issue exists, please provide reasoning for PR.

Overview of PR

Provide an overview of the changes in this PR.

Don't forget to update the CHANGELOG.md file with any changes that are in this PR

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Aug 2, 2019

this is great! I've been working on implementing a row renderer that might help support this as well. I am gonna compare them when I have a good version of my solution
@prh7 thank you so much for the work

@prh7
Copy link
Author

prh7 commented Aug 5, 2019

@Ilaiwi - Can you provide code sandbox of how you are intending to drag and drop of item from one timeline to the other?

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Aug 5, 2019

@prh7 I am working on it. It is gonna take few weeks I guess to get their. I might just post the branch I am doing the work in here.

could you also please resolve the conflict and make the PR aginst develop instead of master?

@prh7
Copy link
Author

prh7 commented Aug 7, 2019

@Ilaiwi - Can I get access as a contributor to the repository? Somehow, I ain't a part of contributor list. I fixed the merge conflicts and made a small demo 'dragDropTimeline' along with other demos locally.

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Aug 8, 2019

@prh7 you don't need to be to fix the conflict. You can set up this repo as the upstream source
git remote add upstream https://github.com/namespace-ee/react-calendar-timeline.git
and do
npm pull upstream develop

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Sep 3, 2019

@prh7 this is only a prototype for now. But this is what to come.
This uses a row renderer feature that I am prototyping in. The drag and drop here is implemented via react-dnd. The cool thing about this feature that the dnd is not built into the timeline but added on top of it.

@prh7
Copy link
Author

prh7 commented Sep 4, 2019

@Ilaiwi - Thank you very much for the great work done. I have two questions:

  1. Can we easily integrate different layers like Gantt layers, etc,. on top of the timeline ?
  2. How performant is it going to behave if we integrate different layers in your perspective?

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Sep 4, 2019

@prh7
1- I am going to experiment with gantt with this new API in the next few months but not sure it will make the public API unfortunately
2- performance-wise this new row renderer concept should have huge positive impact on the performance. for the layers, it will depend on your implementation more than how the library handles things (please note code I linked is a prototype and the idea here is not performance)

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Nov 8, 2019

I released rowRenderer in beta which has an example that does this
#656 (comment)

@Ilaiwi Ilaiwi closed this Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants