Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed timeline onScroll handler min and max value #834

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

StoikovOleh
Copy link

@StoikovOleh StoikovOleh commented Sep 30, 2021

addressed Issue: #805, and probably more.

Overview of PR

fixed scroll of the timeline to prevent scrolling behind visibleTimeStart and visibleTimeEnd min and max values

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Oct 15, 2021

@StoikovOleh I tried to run this with the code for #805 but it didn't work.
Also, do you maybe have a more specific example of a bug that this PR would eliminate?

@StoikovOleh
Copy link
Author

StoikovOleh commented Oct 20, 2021

@StoikovOleh I tried to run this with the code for #805 but it didn't work. Also, do you maybe have a more specific example of a bug that this PR would eliminate?

@Ilaiwi Yo are able scroll to the next and previous day, despite the fact visibleTimeStart and visibleTimeEnd is alway the start and the end of the one day

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Oct 20, 2021

@StoikovOleh yes using trackpads only.

@StoikovOleh
Copy link
Author

StoikovOleh commented Oct 20, 2021

@Ilaiwi, yes, it causing bugs on our project, because we didn't suppose that we could scroll futher then min or max value, you can message me in the telegram @OStoikov

@StoikovOleh
Copy link
Author

StoikovOleh commented Oct 20, 2021

I saw some code in your lib which was suppose to fix it but it was removed in the newer version

@Ilaiwi
Copy link
Collaborator

Ilaiwi commented Nov 2, 2021

@StoikovOleh what method were you using to scroll? Was it programmatically or via trackpad/mouse?

@StoikovOleh
Copy link
Author

@StoikovOleh what method were you using to scroll? Was it programmatically or via trackpad/mouse?

trackpad

@StoikovOleh
Copy link
Author

@Ilaiwi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants