Fix an issue where on POSIX-like filesystems first '/' in absolute file path would be lost. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
I have stumbled across the same issue as #42 and I think I have found the cause.
Using
path.join('./', context, importThisFile)
in the file reading function for#import
directive of mock files just so happens to be removing the first '/' from the absolute file path on POSIX-like file systems. So instead of/user/something/whatever/file.json
one would getuser/something/whatever/file.json
which would cause an error.Since this issue seems to be relatively not very popular I guess it only happens under some circumstances. It appears to be that using just
path.join(context, importThisFile)
will solve this problem. I'm not sure whypath.join('./', context, importThisFile)
was used before since "context" variable is assignedpath.parse(file).dir + '/'
in the code and NodeJS docks say it will evaluate to an absolute directory path on both file systems anyway. Please correct me if I'm wrong here.Please review this and merge if necessary.