Skip to content

Commit

Permalink
blkdeviotune: improve test log
Browse files Browse the repository at this point in the history
The test case needs the output from 'blkdeviotune' on the disk in order
to compare it with the XML values.

It was trying to compare with an empty dictionary because the result was
empty with an error that was ignored.

Don't continue the test if the block I/O throttle parameters cannot be
retrieved. This will show a test error indicating this.

Signed-off-by: Sebastian Mitterle <[email protected]>
  • Loading branch information
smitterl committed Jan 29, 2024
1 parent 6304db0 commit cbddd15
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libvirt/tests/src/virsh_cmd/domain/virsh_blkdeviotune.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def check_blkdeviotune(params):
vm = params.get("vm")
options = params.get("blkdevio_options")
device = params.get("device_name", "")
result = virsh.blkdeviotune(vm_name, device)
result = virsh.blkdeviotune(vm_name, device, ignore_status=False)
dicts = {}
# Parsing command output and putting them into python dictionary.
cmd_output = result.stdout.strip().splitlines()
Expand Down

0 comments on commit cbddd15

Please sign in to comment.