Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace user/password in URL with HTTP header Basic authentication, to avoid credentials ending up in log files #50

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Nov 6, 2023

Fixes #49

@jbemmel jbemmel merged commit 1197aef into main Nov 6, 2023
12 checks passed
@jbemmel jbemmel deleted the use-http-header-authentication branch November 6, 2023 18:15
@jbemmel
Copy link
Collaborator Author

jbemmel commented Nov 6, 2023

Test to validate that HTTP Basic Authentication works too:

curl --user 'admin:NokiaSrl1!' -s 'http://clab-napalm-ci_cd-srl/jsonrpc' -d @- <<EOF | jq
{
    "jsonrpc": "2.0",
    "id": 0,
    "method": "get",
    "params": {
        "commands": [
            {
                "path": "/system/information/version",
                "datastore": "state"
            }
        ]
    }
}
EOF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON RPC credentials exposed in error logs
1 participant