-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.5 (rewriting the world) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not use bem-tools internal modules like `nodesregistry` - use explicitly defined node's names instead of constants
Don't actualy remember why do we need it
- bem-core addded as submodule - makefile to rule them all
fix npm-dependencies
fix for "Error: Can't remove active job(<setName>.examples/<block>/.bem/level.js) from plan(4)" with bem-server usage.
Проверил сборку тестов в bem-core + сборку примеров на islassistant — работает |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @arikon @SevInf @veged
Практически полностью переписал внутренности:
.sets
. Такого понятия больше нет. Вместо этого все собирается в<setName>.<tech>
, в корне проекта.Например,
desktop.examples
,common.tests
(fixes Точечные цели для сборки технологий сета #36);.sets
позволяет просто решить проблему «собрать только все тесты».<setName>.sets
.SetsLevelNode#getSourceItemTechs
, вSetsNode#getSoutceTechs
;test-tmpl
вtest.bemjson.js
;<test-tech-name>
вместоdefault
.Например,
desktop.tests/dom/test-js
,desktop.tests/jquery__event_type_pointer/test-js+browser-js+bemhtml
;vanilla.js
andnode.js
#11);CreateLevelNode
, внутри теперь используетсяBemCreateLevelNode
(обвязка надbem.api.create.level
) — нужно для упрощения файловой структуры;phantomjs
tech to be run bybem create
command #55);make test
в корне репозитория)