feat: spark like .list namespace and lazyframe .explode
#1887
+102
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
added
enhancement
FBruzzesi
commented
Jan 28, 2025
narwhals/_spark_like/dataframe.py
Outdated
Comment on lines
366
to
370
| msg = ( | ||
| "Exploding on multiple columns is not supported with SparkLike backend since " | ||
| "we cannot guarantee that the exploded columns have matching element counts." | ||
| ) | ||
| raise NotImplementedError(msg) |
There was a problem hiding this comment.
In a way... this is so sad since I had a great way of doing it! But cannot verify that the element counts are same without triggering a collect
FBruzzesi
commented
Jan 28, 2025
EdAbati
reviewed
Jan 30, 2025
FBruzzesi
changed the title
.list namespace and lazyframe .explode
FBruzzesi
changed the title
.list namespace and lazyframe .explode.list namespace and lazyframe .explode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below