feat: add LazyFrame.unpivot for spark and duckdb
#1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
added
enhancement
FBruzzesi
commented
Jan 28, 2025
Comment on lines
+417
to
+423
| if variable_name == "": | ||
| msg = "`variable_name` cannot be empty string for duckdb backend." | ||
| raise NotImplementedError(msg) | ||
|
|
||
| if value_name == "": | ||
| msg = "`value_name` cannot be empty string for duckdb backend." | ||
| raise NotImplementedError(msg) |
There was a problem hiding this comment.
I tried, but it is not of duckdb liking to support these
|
thanks, can you rebase please? |
MarcoGorelli
reviewed
Feb 2, 2025
MarcoGorelli
reviewed
Feb 2, 2025
MarcoGorelli
reviewed
Feb 2, 2025
| @@ -312,3 +312,21 @@ def join( | |||
| return self._from_native_frame( | |||
| self_native.join(other, on=left_on, how=how).select(col_order) | |||
| ) | |||
|
|
|||
| def unpivot( | |||
FBruzzesi
commented
Feb 2, 2025
narwhals/dataframe.py
Outdated
| ) | ||
|
|
||
| if on_ is None: | ||
| on_ = [c for c in self.collect_schema().names() if c not in index_] |
There was a problem hiding this comment.
@MarcoGorelli by pushing one level up, we (might) need column names 🙃
There was a problem hiding this comment.
ah sorry i don't think we need to push this one, just the str | list[str] ones
MarcoGorelli
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
thanks @FBruzzesi ! feel free to merge on green
got a question which occurred to me, we can always simplify later
Comment on lines
+342
to
+343
| variable_name = variable_name if variable_name is not None else "variable" | ||
| value_name = value_name if value_name is not None else "value" |
There was a problem hiding this comment.
🤔 I don't understand why the signature isn't variable_name: str = "variable" in Polars, am I missing something?
There was a problem hiding this comment.
Good point! Not sure why they do it like that
MarcoGorelli
reviewed
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below