docs: shorten docstring examples in narwhals/expr.py #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
10 tasks
|
gonna ship this then, as we'd discussed this in Friday's call (https://hackmd.io/HJdFvJhjQl2iXMUDpVf_9Q) and people were on board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot helped me to shorten the docstrings
I then went through and fixup out the outputs, and sometimes fixed up the examples too
Aside from reducing size, I think like this they're more to-the-point
We could then have some follow-up PRs to diversity the examples a bit to showcase different libraries
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below