Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9878: CodeSystemIdentifierMeaning maxlength to 1024, minItems to 1 #2205

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

htranho
Copy link
Contributor

@htranho htranho commented Jan 3, 2025

Overview

What is the feature/fix?

Update length of Variable - CodeSystemIdentifierMeaning field from 60 to 1024 and minItems to 1.

What is the Solution?

Update json schema file for Variable.

What areas of the application does this impact?

Ingest of Variable - field CodeSystemIdentifierMeaning.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@htranho htranho changed the title CMR-9878: CodeSystemIdentifierMeaning maxlength to 1024 and minItems … CMR-9878: CodeSystemIdentifierMeaning maxlength to 1024, minItems to 1 Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.32%. Comparing base (2931b87) to head (2ab31e8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   29.32%   29.32%           
=======================================
  Files         996      996           
  Lines       67728    67728           
  Branches     1217     1217           
=======================================
  Hits        19863    19863           
  Misses      46721    46721           
  Partials     1144     1144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@htranho htranho merged commit 553d1ab into master Jan 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants