Fix #299, Sleep before exit when printing #301

paulober · 2021-08-29T10:04:37Z

Describe the contribution

Fixes Add sleep(1) before exit call when printing #299

Expected behavior changes

Print before exit [Add sleep(1) before exit call when printing #299]

Additional context

Considering if 100 milliseconds would be better than 1000 to save time and have a print.
Considering fflush(stdout) instead of OS_TaskDelay

Contributor Info - All information REQUIRED for consideration of pull request
Paul Oberosler, Individual

jphickey

This has come up a time or two, the root of the problem is really that OS_printf is now always associated with a background task/local OSAL bufffer to do the output. This makes it so its always buffered consistently across platforms.

The price of that consistency, is that in previous versions, OS_printf on POSIX was just directly going to the libc printf, but now it's got an extra buffer in the middle.

Rather than adding a blanket delay - which is not ideal as its much longer than it really needs to be, while also not even guaranteeing that the output was flushed - since this is the PC-Linux PSP, and therefore known to be running on this platform, we should be using some form of perror here, or at least converting to fprintf(stderr, ....

Note that stderr stream is unbuffered, so there should not be any problem with immediately calling exit() afterwards.

jphickey · 2021-09-01T15:33:52Z

Another option/suggestion would be to use the CFE_PSP_Panic function instead of exiting immediately from here. It's not much better as it stands (it still just does an abort, does not flush the OS_printf queue either) but at least it could provide a single point for doing so, rather than sprinkling OS_TaskDelay everywhere.

jphickey · 2021-09-01T15:37:36Z

Also note that if we are touching these error message, I would like to see it report the actual errno in some form (at least the number, but preferably the string as obtained from strerror() or perror()). These error messages as they stand are too vague to be useful. While I realize this wasn't part of the original bug, this would be a good improvement IMO if we are touching the lines anyway.

jphickey · 2021-09-01T15:50:02Z

FYI: I wrote issue #302 so as to not forget about this, it doesn't have to be part of this PR necessarily.

skliper

I like the CFE_PSP_Panic suggestion to replace the OS_TaskDelay and exit.

paulober · 2021-09-21T20:30:57Z

Ok, thanks for all the information. I have now used CFE_PSP_Panic as well as perror to handle the error.
Perror should now do an output in the following format: ": "
Does this meet your requested changes?

jphickey

Changes look good!

Only required cleanup now is to squash down the multiple commits and rewrite the log message for merging.

paulober · 2021-09-22T18:47:44Z

Changes look good!

Ok, great.

Only required cleanup now is to squash down the multiple commits and rewrite the log message for merging.

Of course, it is already done. I will push it right away.

astrogeco · 2021-10-13T16:19:20Z

CCB:2021-10-13 APPROVED

nasa/cFE#1995 nasa/cFE#1873 nasa/PSP#301 nasa/PSP#314 nasa/osal#1178 nasa/osal#1168 nasa/osal#1169 nasa/osal#1180 nasa/osal#1112

Combines: nasa/cFE#2001 nasa/osal#1191 nasa/PSP#318 Includes: - nasa/cFE#1663, Use cfe time clock state enum t in cmd/tlm and handling - nasa/cFE#1973, EVS functional test add for different event types - nasa/cFE#1954, Patch for recursive event loop - nasa/cFE#1911, CFE_ES_MemAddOff structure to associated CFE_ES_MemAddress_t and CFE_ES_MemOffset_t - nasa/cFE#1986, Avoid aliasing warnings - nasa/cFE#1975, Message ID type improvements - nasa/cFE#1974, CFE_SB_ValueToMsgId/MsgIdToValue wrappers - nasa/cFE#1663, Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling - nasa/cFE#1995, Consolidate repeated MSG stub setup in sb_UT - nasa/cFE#1873, Return type conversions in CFE_ES_GetTaskName - nasa/cFE#1966, Better message type pointer conversion - nasa/cFE#2002, Replacing hardcoded message limit in TIME services - nasa/cFE#1909, Use macro in CFE_ResourceId_IsDefined - nasa/cFE#1999, Checking against IsNewOffset only - nasa/osal#1186, Add Duplicate Check to Local Unit Test - nasa/osal#1178, Rename OS_XXXTime to OS_XXXLocalTime in comments - nasa/osal#1168, Fix vxWorks intLib stub aliasing issue - nasa/osal#1169, Recognize ifdef __cplusplus - nasa/osal#1180, Remove extern in stub prototypes - nasa/osal#1112, Add typedef for OSAL status codes - nasa/PSP#301, Sleep before exit when printing - nasa/PSP#314, Check the address in PSP get segment stubs - nasa/elf2cfetbl#89, Check get_sh_entsize(SectionHeader) value - nasa/cFS-GroundSystem#197, Free Address Info for Leak - nasa/sch_lab#95, use separate address variable - nasa/sch_lab#94, Use CFE_MSG_PTR conversion macro - nasa/sample_app#157, Use CFE_MSG_PTR conversion macro - nasa/ci_lab#95, Use CFE_MSG_PTR conversion macro - nasa/to_lab#107, Use CFE_MSG_PTR conversion macro - nasa/elf2cfetbl#93, Check get_sh_entsize(SectionHeader) value Co-authored by: Jacob Hageman [email protected] Co-authored by: Joseph Hickey [email protected] Co-authored by: Ariel Adams [email protected] Co-authored by: Paul [email protected] Co-authored by: Zachary Gonzalez [email protected] Co-authored by: Sam Price [email protected] Co-authored by: Shefali Sharma [email protected]

Combines: nasa/cFE#2001 nasa/osal#1191 nasa/PSP#318 Includes: - nasa/cFE#1663, Use cfe time clock state enum t in cmd/tlm and handling - nasa/cFE#1973, EVS functional test add for different event types - nasa/cFE#1954, Patch for recursive event loop - nasa/cFE#1911, CFE_ES_MemAddOff structure to associated CFE_ES_MemAddress_t and CFE_ES_MemOffset_t - nasa/cFE#1986, Avoid aliasing warnings - nasa/cFE#1975, Message ID type improvements - nasa/cFE#1974, CFE_SB_ValueToMsgId/MsgIdToValue wrappers - nasa/cFE#1663, Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling - nasa/cFE#1995, Consolidate repeated MSG stub setup in sb_UT - nasa/cFE#1873, Return type conversions in CFE_ES_GetTaskName - nasa/cFE#1966, Better message type pointer conversion - nasa/cFE#2002, Replacing hardcoded message limit in TIME services - nasa/cFE#1909, Use macro in CFE_ResourceId_IsDefined - nasa/cFE#1999, Checking against IsNewOffset only - nasa/osal#1186, Add Duplicate Check to Local Unit Test - nasa/osal#1178, Rename OS_XXXTime to OS_XXXLocalTime in comments - nasa/osal#1168, Fix vxWorks intLib stub aliasing issue - nasa/osal#1169, Recognize ifdef __cplusplus - nasa/osal#1180, Remove extern in stub prototypes - nasa/osal#1112, Add typedef for OSAL status codes - nasa/PSP#301, Sleep before exit when printing - nasa/PSP#314, Check the address in PSP get segment stubs - nasa/elf2cfetbl#89, Check get_sh_entsize(SectionHeader) value - nasa/cFS-GroundSystem#197, Free Address Info for Leak - nasa/sch_lab#95, use separate address variable - nasa/sch_lab#94, Use CFE_MSG_PTR conversion macro - nasa/sample_app#157, Use CFE_MSG_PTR conversion macro - nasa/ci_lab#95, Use CFE_MSG_PTR conversion macro - nasa/to_lab#107, Use CFE_MSG_PTR conversion macro - nasa/elf2cfetbl#93, Check get_sh_entsize(SectionHeader) value Co-authored by: Jacob Hageman <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Ariel Adams <[email protected]> Co-authored by: Paul <[email protected]> Co-authored by: Zachary Gonzalez <[email protected]> Co-authored by: Sam Price <[email protected]> Co-authored by: Shefali Sharma <[email protected]>

Combines: nasa/cFE#2001 nasa/osal#1191 nasa/PSP#318 Includes: - nasa/cFE#1663, Use cfe time clock state enum t in cmd/tlm and handling - nasa/cFE#1973, EVS functional test add for different event types - nasa/cFE#1954, Patch for recursive event loop - nasa/cFE#1911, CFE_ES_MemAddOff structure to associated CFE_ES_MemAddress_t and CFE_ES_MemOffset_t - nasa/cFE#1986, Avoid aliasing warnings - nasa/cFE#1975, Message ID type improvements - nasa/cFE#1974, CFE_SB_ValueToMsgId/MsgIdToValue wrappers - nasa/cFE#1663, Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling - nasa/cFE#1995, Consolidate repeated MSG stub setup in sb_UT - nasa/cFE#1873, Return type conversions in CFE_ES_GetTaskName - nasa/cFE#1966, Better message type pointer conversion - nasa/cFE#2002, Replacing hardcoded message limit in TIME services - nasa/cFE#1909, Use macro in CFE_ResourceId_IsDefined - nasa/cFE#1999, Checking against IsNewOffset only - nasa/osal#1186, Add Duplicate Check to Local Unit Test - nasa/osal#1178, Rename OS_XXXTime to OS_XXXLocalTime in comments - nasa/osal#1168, Fix vxWorks intLib stub aliasing issue - nasa/osal#1169, Recognize ifdef __cplusplus - nasa/osal#1180, Remove extern in stub prototypes - nasa/osal#1112, Add typedef for OSAL status codes - nasa/PSP#301, Sleep before exit when printing - nasa/PSP#314, Check the address in PSP get segment stubs - nasa/elf2cfetbl#89, Check get_sh_entsize(SectionHeader) value - nasa/cFS-GroundSystem#197, Free Address Info for Leak - nasa/sch_lab#95, use separate address variable - nasa/sch_lab#94, Use CFE_MSG_PTR conversion macro - nasa/sample_app#157, Use CFE_MSG_PTR conversion macro - nasa/ci_lab#95, Use CFE_MSG_PTR conversion macro - nasa/to_lab#107, Use CFE_MSG_PTR conversion macro - nasa/elf2cfetbl#93, Check get_sh_entsize(SectionHeader) value Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: Zachary Gonzalez <[email protected]> Co-authored-by: Sam Price <[email protected]> Co-authored-by: Shefali Sharma <[email protected]>

Combines: nasa/cFE#2001 nasa/osal#1191 nasa/PSP#318 nasa/ci_lab#101 nasa/sch_lab#102 nasa/to_lab#112 nasa/sample_app#163 nasa/cFS-GroundSystem#201 nasa/elf2cfetbl#98 Includes: *cFE* - nasa/cFE#1663, Use cfe time clock state enum t in cmd/tlm and handling - nasa/cFE#1973, EVS functional test add for different event types - nasa/cFE#1954, Patch for recursive event loop - nasa/cFE#1911, CFE_ES_MemAddOff structure to associated CFE_ES_MemAddress_t and CFE_ES_MemOffset_t - nasa/cFE#1986, Avoid aliasing warnings - nasa/cFE#1975, Message ID type improvements - nasa/cFE#1974, CFE_SB_ValueToMsgId/MsgIdToValue wrappers - nasa/cFE#1663, Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling - nasa/cFE#1995, Consolidate repeated MSG stub setup in sb_UT - nasa/cFE#1873, Return type conversions in CFE_ES_GetTaskName - nasa/cFE#1966, Better message type pointer conversion - nasa/cFE#2002, Replacing hardcoded message limit in TIME services - nasa/cFE#1909, Use macro in CFE_ResourceId_IsDefined - nasa/cFE#1999, Checking against IsNewOffset only *osal* - nasa/osal#1186, Add Duplicate Check to Local Unit Test - nasa/osal#1178, Rename OS_XXXTime to OS_XXXLocalTime in comments - nasa/osal#1168, Fix vxWorks intLib stub aliasing issue - nasa/osal#1169, Recognize ifdef __cplusplus - nasa/osal#1180, Remove extern in stub prototypes - nasa/osal#1112, Add typedef for OSAL status codes *PSP* - nasa/PSP#301, Sleep before exit when printing - nasa/PSP#314, Check the address in PSP get segment stubs *Tools* - nasa/elf2cfetbl#89, Check get_sh_entsize(SectionHeader) value - nasa/elf2cfetbl#93, Check get_sh_entsize(SectionHeader) value - nasa/cFS-GroundSystem#197, Free Address Info for Leak *Apps* - nasa/sch_lab#95, use separate address variable - nasa/sch_lab#94, Use CFE_MSG_PTR conversion macro - nasa/sample_app#157, Use CFE_MSG_PTR conversion macro - nasa/ci_lab#95, Use CFE_MSG_PTR conversion macro - nasa/to_lab#107, Use CFE_MSG_PTR conversion macro Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Ariel Adams <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: Zachary Gonzalez <[email protected]> Co-authored-by: Sam Price <[email protected]> Co-authored-by: Shefali Sharma <[email protected]>

skliper requested a review from jphickey August 30, 2021 12:52

astrogeco added the community label Aug 30, 2021

paulober marked this pull request as ready for review August 30, 2021 23:16

jphickey requested changes Sep 1, 2021

View reviewed changes

astrogeco requested a review from skliper September 20, 2021 19:03

skliper reviewed Sep 20, 2021

View reviewed changes

paulober requested a review from jphickey September 21, 2021 20:26

paulober force-pushed the fix-299-sleep-before-exit branch from 879ea05 to f587528 Compare September 21, 2021 20:39

skliper approved these changes Sep 21, 2021

View reviewed changes

jphickey approved these changes Sep 22, 2021

View reviewed changes

Fix nasa#299, Sleep before exit when printing

bf9b935

paulober force-pushed the fix-299-sleep-before-exit branch from f587528 to bf9b935 Compare September 22, 2021 18:47

astrogeco added the CCB:Approved Indicates Approval by CCB label Oct 13, 2021

skliper added this to the Draco milestone Oct 29, 2021

astrogeco mentioned this pull request Nov 3, 2021

psp Integration candidate: Caelum+dev1 #318

Merged

astrogeco added a commit to astrogeco/cFS that referenced this pull request Nov 3, 2021

IC:Caelum+dev1

9224080

nasa/cFE#1995 nasa/cFE#1873 nasa/PSP#301 nasa/PSP#314 nasa/osal#1178 nasa/osal#1168 nasa/osal#1169 nasa/osal#1180 nasa/osal#1112

astrogeco mentioned this pull request Nov 17, 2021

cFS Bundle Integration candidate: Caelum+dev1 nasa/cFS#390

Merged

2 tasks

astrogeco merged commit 20a2a34 into nasa:main Dec 6, 2021

paulober deleted the fix-299-sleep-before-exit branch June 9, 2023 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #299, Sleep before exit when printing #301

Fix #299, Sleep before exit when printing #301

paulober commented Aug 29, 2021

jphickey left a comment

jphickey commented Sep 1, 2021

jphickey commented Sep 1, 2021

jphickey commented Sep 1, 2021

skliper left a comment

paulober commented Sep 21, 2021

jphickey left a comment

paulober commented Sep 22, 2021

astrogeco commented Oct 13, 2021

Fix #299, Sleep before exit when printing #301

Fix #299, Sleep before exit when printing #301

Conversation

paulober commented Aug 29, 2021

jphickey left a comment

Choose a reason for hiding this comment

jphickey commented Sep 1, 2021

jphickey commented Sep 1, 2021

jphickey commented Sep 1, 2021

skliper left a comment

Choose a reason for hiding this comment

paulober commented Sep 21, 2021

jphickey left a comment

Choose a reason for hiding this comment

paulober commented Sep 22, 2021

astrogeco commented Oct 13, 2021