-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAS-1601 - Update platform for service Docker image to AMD64. #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I hate the conda but understand how you got there.
Two things. How did the tests run before on github actions? I don't see any runs in the actions.
I forked this trying to figure out how the actions worked and there are two warnings you might address.
https://github.com/flamingbear/harmony-gdal-adapter/actions/runs/11206162507
"The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/login-action@v2, docker/metadata-action@v4, docker/build-push-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/"
and:
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Coverage report for Python", "Test results for Python".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Since you're here you might update those actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I hate the conda but understand how you got there.
Two things. How did the tests run before on github actions? I don't see any runs in the actions.
I forked this trying to figure out how the actions worked and there are two warnings you might address.
https://github.com/flamingbear/harmony-gdal-adapter/actions/runs/11206162507
"The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/login-action@v2, docker/metadata-action@v4, docker/build-push-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/"
and:
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Coverage report for Python", "Test results for Python".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Since you're here you might update those actions.
@flamingbear - good call on updating the stale versions of the GitHub actions. I've bumped those, and the things in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, is testing on my intel mac.
Description
This PR is from a bit of a rabbit hole. I have made some changes to Harmony locally to prevent the ability to request PNGs or GIFs from HGA. To test that locally, I need the HGA image to work with Harmony in a Box - but I've changed machines since last running HiaB, and needed to update the
--platform
argument in thedocker build
command to make it all work.Then for the rabbit hole - the
Dockerfile
was trying to pull in some things that had an issue, so I couldn't build the image without updating the source image that was being used. I tried a couple of approaches:apt-get install libgdal-dev
, but that also had a couple of issues).All this, just to remove some functionality!
Bonus: I updated the change log to be consistent with our other projects. I haven't added URLs to the tags, because those tags don't all exist. (I might go through and manually make them a little later)
Jira Issue ID
DAS-1601 - Sort of. This PR enables testing of the Harmony core changes to switch off the ability to make requests that would run the code that should be removed in DAS-1601.
Local Test Steps
./bin/build-image && ./bin/build-test && ./bin/run-test
.PR Acceptance Checklist
Jira ticket acceptance criteria met.- Preliminary work.version.txt
andCHANGE.md
updated if any service code is changed.added/updatedand passing.