Fix paths and regenerate files after recent changes #127
Conversation
|
The changes to the modules are going to conflict with this one: #125 |
Sorry, I must have missed the notification email about your PR and wish I had looked it over first. Without reviewing in detail yet, I suspect that your PR doesn't address all the issues this one does, but maybe gets some of them? Also, this would be the third time somebody is rearranging the directory structure since I started writing these scripts, and every time it broke the scripts and I had to fix them. If you are moving things around again, please make sure you can run the three Python scripts without any arguments and they do something sane. |
|
Yes, I haven't touched the yaml files or PDDL files. |
trey0
force-pushed
the
regenerate_planner_files
branch
from
6ee8b3c
to
ec1a7eb
Compare
|
Started over from scratch, making similar updates starting from the version of |
| - name: Run isort | ||
| run: | | ||
| isort . --diff --extend-skip cmake --profile black --check-only | ||
| isort . --diff --extend-skip=cmake --extend-skip=submodules --extend-skip=astrobee/survey_manager/survey_dependencies --profile=black --check-only |
There was a problem hiding this comment.
(Skipping folders of external code we shouldn't lint.)
| "--extend-skip=astrobee/survey_manager/survey_dependencies" | ||
| "--profile=black" | ||
| ) | ||
| if $(isort . "${isort_args[@]}" --diff --check-only --quiet >/dev/null); then |
There was a problem hiding this comment.
It's important to use . here as explained in the comment above and not restrict isort to looking at changed files. The --extend-skip stuff is to avoid linting external code.
Note this is following how it's done in the astrobee repo, except in my local testing I found that you need to use multiple --extend-skip arguments instead of a single arg with a comma-separated list.
Should be an easy review. Just fixing breakage from other recent PRs, no substantive changes.