sch_lab Integration candidate: Caelum-rc4+dev64 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'status' variable
Fix #128, Standardize naming of SCH_LAB functions/macros
…Status Fix #148, Call CFE_ES_ExitApp with RunStatus rather than internal status variable
…codes-to-CFE_Status_t Fix #141, Convert int32 return codes and variables to CFE_Status_t
…ific-cfe-headers Fix #133, Remove component-specific cFE header #includes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /* | ||
| ** AppMain | ||
| */ | ||
| void SCH_Lab_AppMain(void) | ||
| void SCH_LAB_AppMain(void) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
|
|
||
| /* | ||
| ** AppMain | ||
| */ | ||
| void SCH_Lab_AppMain(void) | ||
| void SCH_LAB_AppMain(void) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -148,10 +148,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 SCH_LAB_AppInit(void) | |||
| CFE_Status_t SCH_LAB_AppInit(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -148,10 +148,10 @@ | |||
| /* Initialization */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| int32 SCH_LAB_AppInit(void) | |||
| CFE_Status_t SCH_LAB_AppInit(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
CFE_ES_ExitAppwithRunStatusrather than internalstatusvariable #149. Addresses IssueCFE_ES_ExitAppcalled with internalstatuscontrol parameter rather thanRunStatus#148int32return codes and variables toCFE_Status_t#142. Addresses Issue sch_labint32return codes and variables should be converted toCFE_Status_t#141Testing performed
cFS Bundle Checks
PSP Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 22.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt