Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bump version workflow #40

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat: update bump version workflow #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f116545
feat: update bump version workflow
khoilen Jan 10, 2025
f567ebc
feat: update typo pr template
khoilen Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull-request-template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Closes #
- [ ] My code requires changes to the documentation
- [ ] I have updated the documentation as required
- [ ] All the tests have passed
- [ ] The dependencies in `package.json` are correct and necessary (no unused or missing package
- [ ] The dependencies in `package.json` are correct and necessary (no unused or missing package)

## ℹ Additional Information

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
echo "new_version=$version" >> $GITHUB_ENV
if [$version != "unknown" ]; then
git checkout -b bump-${{ github.event.inputs.app }}-version-$version
git add .
git add apps/${{ github.event.inputs.app }}/package.json
git commit -m "Bump ${{ github.event.inputs.app }} version to $version"
git tag "v$version"
git push origin bump-${{ github.event.inputs.app }}-version-$version --follow-tags
Expand All @@ -79,5 +79,5 @@ jobs:
title: "Bump version to ${{ env.new_version }} for ${{ github.event.inputs.app }}"
body: "This PR bumps the version to ${{ env.new_version }} for ${{ github.event.inputs.app }}."
labels: version-bump
assignees: khoilen
reviewers: khoilen
assignees: khoilen, tintungtang
reviewers: khoilen, tintungtang
Loading