Fix failing investspec test #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcdenu4
requested changes
Mar 7, 2023
There was a problem hiding this comment.
Hey @emlys, I know this is a bit tedious but should we update other places and documentation where MODEL_SPEC is replacing ARGS_SPEC?
I did a quick grep grep -r --exclude-dir=.git/ "ARGS_SPEC" ./* and found
- ./extensions/investspec/investspec.py
- ./extensions/investspec/README.md
Might need some quick updates.
|
Ugh, sorry, I really thought I did that already. Done now |
dcdenu4
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #119
The checks aren't running here for some reason (🤯) but you can see them on my branch: https://github.com/emlys/invest.users-guide/actions/runs/4358019774/jobs/7618058964