-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to communicate new raster output units (InVEST #1270) #158
Updates to communicate new raster output units (InVEST #1270) #158
Conversation
…ure/1270-per-hectare-outputs
Stouffer, P., Gascon, C., Bierregaard, R., Laurance, S., Sampaio, E., | ||
2002. Ecosystem decay of Amazonian forest fragments: a 22-year | ||
Stouffer, P., Gascon, C., Bierregaard, R., Laurance, S., Sampaio, E., 2002. | ||
Ecosystem decay of Amazonian forest fragments: a 22-year | ||
investigation. Conservation Biology 16, 605–618. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a previous commit, 2002.
was somehow converted to 1.
in my code editor. My theory is, the line beginning with 2002.
was interpreted as a list item, so I moved 2002.
to the end of the previous line to prevent this from happening in the future.
… into feature/1270-per-hectare-outputs
source/en/carbon_edge.rst
Outdated
summarizes the total carbon (column *c_sum*) and mean carbon per | ||
ha (column *c_ha_mean*) in the area polygons defined. Values are | ||
in Mg. | ||
- **Parameter log**. Each time the model is run, a text (.txt) file will appear in the *Workspace*. The file will list the parameter values for that run and will be named according to the service, the date and time. When contacting NatCap about errors in a model run, please include the parameter log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No substantive changes to this paragraph, only formatting.
source/en/carbon_edge.rst
Outdated
in Mg. | ||
- **Parameter log**. Each time the model is run, a text (.txt) file will appear in the *Workspace*. The file will list the parameter values for that run and will be named according to the service, the date and time. When contacting NatCap about errors in a model run, please include the parameter log. | ||
|
||
- **carbon_map_[Suffix].tif**. A map of carbon stock, with the amount in forest derived from the regression based on distance to forest edge, and the amount in non-forest classes according to the biophysical table. Units are metric tons per hectare (Mg/ha). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed "per pixel" and removed the note about how values change with pixel size (no longer relevant since values are no longer per pixel).
source/en/carbon_edge.rst
Outdated
|
||
- **carbon_map_[Suffix].tif**. A map of carbon stock, with the amount in forest derived from the regression based on distance to forest edge, and the amount in non-forest classes according to the biophysical table. Units are metric tons per hectare (Mg/ha). | ||
|
||
- **aggregated_carbon_stocks_[Suffix].shp**: If service areas of interest are provided by the user, this output shapefile summarizes the total carbon (column *c_sum*) and mean carbon per ha (column *c_ha_mean*) in the area polygons defined. Values are in metric tons (Mg). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed "Mg" to "metric tons (Mg)", for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes, the most frequent and relevant being replacing Mg
with t
.
I'm less confident about formatting when listing units of measure, but I was going for some consistency with the "Data Needs" sections. Of course, these aren't consistent across model chapters, but it would be great if they were!
source/en/carbon_edge.rst
Outdated
in Mg. | ||
- **Parameter log**. Each time the model is run, a text (.txt) file will appear in the *Workspace*. The file will list the parameter values for that run and will be named according to the service, the date and time. When contacting NatCap about errors in a model run, please include the parameter log. | ||
|
||
- **carbon_map_[Suffix].tif**. A map of carbon stock, with the amount in forest derived from the regression based on distance to forest edge, and the amount in non-forest classes according to the biophysical table. Units are metric tons per hectare (Mg/ha). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **carbon_map_[Suffix].tif**. A map of carbon stock, with the amount in forest derived from the regression based on distance to forest edge, and the amount in non-forest classes according to the biophysical table. Units are metric tons per hectare (Mg/ha). | |
- **carbon_map_[Suffix].tif**. A map of carbon stock, with the amount in forest derived from the regression based on distance to forest edge, and the amount in non-forest classes according to the biophysical table. Units are metric tons per hectare (t/ha). | |
Mg
notation should be removed all together and replaced with t
as "megagrams" are being replaced with "tons". Listing "Mg" as the abbreviation for "metric tons" would likely only add to users' confusion.
|
||
* **avoid_eros** (units: tons/watershed/year): The sum of avoided local erosion in the watershed (Sum of :math:`AER_i` from :eq:`aer_i` over the watershed area) | ||
* **avoid_eros** (units: metric tons/watershed/year): The sum of avoided local erosion in the watershed (Sum of :math:`AER_i` from :eq:`aer_i` over the watershed area) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **avoid_eros** (units: metric tons/watershed/year): The sum of avoided local erosion in the watershed (Sum of :math:`AER_i` from :eq:`aer_i` over the watershed area) | |
* **avoid_eros** (units: t/(watershed*year)): The sum of avoided local erosion in the watershed (Sum of :math:`AER_i` from :eq:`aer_i` over the watershed area) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual inclination is to spell things out as much as possible, and consistently. So personally I'd be more in favor of "metric tons/(watershed*year)" (or "metric tons/watershed/year", which reads a little more clearly to me, but let's pick one way of writing it and do it consistently throughout the UG). If I was a beginner with the models, I'm not sure I'd know what "t" stands for.
|
||
* **sed_dep** (units: tons/watershed/year): Total amount of sediment deposited on the landscape in each watershed, which does not enter the stream. (Sum of :math:`T_i` from :eq:`ti` over the watershed area) | ||
* **sed_dep** (units: metric tons/watershed/year): Total amount of sediment deposited on the landscape in each watershed, which does not enter the stream. (Sum of :math:`T_i` from :eq:`ti` over the watershed area) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **sed_dep** (units: metric tons/watershed/year): Total amount of sediment deposited on the landscape in each watershed, which does not enter the stream. (Sum of :math:`T_i` from :eq:`ti` over the watershed area) | |
* **sed_dep** (units: t/(watershed*year)): Total amount of sediment deposited on the landscape in each watershed, which does not enter the stream. (Sum of :math:`T_i` from :eq:`ti` over the watershed area) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual inclination is to spell things out as much as possible, and consistently. So personally I'd be more in favor of "metric tons/(watershed*year)" (or "metric tons/watershed/year", which reads a little more clearly to me, but let's pick one way of writing it and do it consistently throughout the UG). If I was a beginner with the models, I'm not sure I'd know what "t" stands for.
@@ -507,9 +507,9 @@ Interpreting Results | |||
|
|||
* **d_up.tif**: upslope factor of the index of connectivity (Eq. :eq:`d_up`) | |||
|
|||
* **e_prime.tif**: sediment downslope deposition, the amount of sediment from a given pixel that does not reach a stream (Eq. :eq:`eprime`) | |||
* **e_prime.tif**: sediment downslope deposition, the amount of sediment from a given pixel that does not reach a stream (Eq. :eq:`eprime`). Units: metric tons/hectare/year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **e_prime.tif**: sediment downslope deposition, the amount of sediment from a given pixel that does not reach a stream (Eq. :eq:`eprime`). Units: metric tons/hectare/year. | |
* **e_prime.tif**: sediment downslope deposition, the amount of sediment from a given pixel that does not reach a stream (Eq. :eq:`eprime`). Units: t/(ha*year). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My usual inclination is to spell things out as much as possible, and consistently. So personally I'd be more in favor of "metric tons/(hectare*year)" (or "metric tons/hectare/year", which reads a little more clearly to me, but let's pick one way of writing it and do it consistently throughout the UG). If I was a beginner with the models, I'm not sure I'd know what "t" stands for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am convinced and concur with Stacie that it's best to spell out to remove any doubt.
…and update punctuation & wording where needed Co-authored-by: Jesse Goldstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates make sense to me. AFAICT they accurately describe the updated models that will produce per hectare raster results, no longer per pixel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! If any confusion arises with public users, we can always make changes later.
Updates the following User Guide pages:
to reflect the changes made in InVEST PR #1717 (see also InVEST #1270).