-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate text between UG and args spec (part 1 of 3) #42
Merged
Merged
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
812cb5e
test commit
emlys 07879aa
start using investspec role in carbon and cbc pages
emlys 321f9fc
draft of consolidating CV
emlys f4a11ab
consolidate delineateit
emlys 0f482ed
improve format
emlys fa68760
update input types
emlys e9dc9ef
undo changes to gha workflow
emlys 3d0c1ff
remove commented out lines"
emlys 794dbf4
minor edits
emlys 460cabd
include columns in tables for CBC, CV
emlys b3f49f2
minor cv edits
emlys 81822d9
list out columns in crop production
emlys bf6d9a7
point to corresponding invest branch in requirements
emlys 9f68222
Update source/input_types.rst
emlys 8564db4
clean up
emlys eff9a91
remove old comment in cv about small coastline features
emlys eee8531
Merge branch 'release/3.10' into task/31/models-A-D
emlys b319575
update to 10 crops only
emlys a5a855c
update requirement to natcap/invest release/3.10
emlys fe28bde
Merge branch 'example/generate-docs' into task/31/models-A-D
emlys 6fb2d0f
undo outdated changes to workflow, makefile
emlys 5db4d07
add variable definitions for carbon equation
emlys 6310bbf
Update source/delineateit.rst
emlys 732d02f
remove question marks
emlys eb3b6bf
Merge branch 'task/31/models-A-D' of https://github.com/emlys/invest.…
emlys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
git-lfs | ||
git+https://github.com/emlys/invest.git@task/invest.users-guide/30 | ||
git+https://github.com/natcap/invest.git@release/3.10 | ||
pint | ||
setuptools_scm | ||
sphinx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the variables in this equation be defined afterwards? Like: where
V
is this and that ,c
is that and this, etc...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd agree, it'd be nice to include these values here. It does look like these values are defined in the parameter descriptions below ... a little obfuscated, but at least they are defined somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I added variable definitions. Though, I didn't change this equation, just moved it from a different section of the text. There are many other places in the UG where variables aren't defined, or are re-used to mean different things, and fixing all that will be a bigger project.