Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle BOMs when loading HRA criteria tables #1461

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Handle BOMs when loading HRA criteria tables #1461

merged 6 commits into from
Dec 11, 2023

Commits on Dec 5, 2023

  1. Fixing and testing UTF-8-SIG for the criteria table. 

    RE:natcap#1460
    @phargogh
    phargogh committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    753bcb3 View commit details
    Browse the repository at this point in the history

  2. Noting change in HISTORY. 

    RE:natcap#1460
    @phargogh
    phargogh committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    dcf897b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/natcap/invest into bugfix/1… 

    …460-hra-csv-bom-loading-issue

Conflicts:
	HISTORY.rst
	src/natcap/invest/hra.py
    @phargogh
    phargogh committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3c07a04 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Using utf-8-sig encoding directly. 

    RE:natcap#1460
    @phargogh
    phargogh committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b19b946 View commit details
    Browse the repository at this point in the history

  2. Making sure the new file is closed after we're done with it. RE:natca… 

    …p#1460
    @phargogh
    phargogh committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4dbe7f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Doing the test by opening the file in binary mode. RE:natcap#1460

    @phargogh
    phargogh committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0bc66be View commit details
    Browse the repository at this point in the history