Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also handling sanitized package names. RE:#1679 #1680

Merged

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented Nov 5, 2024

This should be a simple fix, just adding the sanitized distribution names to the twine upload command. Further context is described in #1679

Fixes #1679

Checklist

- [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
- [ ] Updated the user's guide (if needed)
- [ ] Tested the Workbench UI (if relevant)

@phargogh phargogh requested a review from emlys November 5, 2024 21:20
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emlys emlys merged commit b304916 into natcap:main Nov 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update source distribution filename in twine upload
2 participants