Feature/1368 display changelog in workbench #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es into a single commit
…play-changelog-in-workbench
emilyanndavis
commented
Nov 8, 2024
davemfish
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks, @emilyanndavis , this works great! Looks like you got the puppeteer tests working. And there's probably something unrelated going on the the GHA Mac runners.
I have mostly minor comments; happy to discuss any of them.
davemfish
approved these changes
Nov 13, 2024
| }; | ||
| document.querySelectorAll('.link-external').forEach(link => { | ||
| link.addEventListener('click', openLinkInBrowser); | ||
| }); |
There was a problem hiding this comment.
This looks like a great solution!
emilyanndavis
deleted the
feature/1368-display-changelog-in-workbench
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1368.
On first launch of a new version, the workbench will display a modal containing the relevant section of the changelog (i.e., only the items that are new in this version).
On the first launch (of any version) ever, the workbench will display the "download sample data" modal as usual. Then, only once the download modal has been closed, the changelog modal will open. Once the changelog modal has been closed, it will not open again.
Note this also supports multiple installed versions. That is, a user who is actively using multiple versions of the workbench will not see the changelog every time they close one version and open another.
Checklist
[ ] Updated the user's guide (if needed)Example
Note the changelog for 3.14.2 is rendered because 3.14.2 is the most recent version. Once a new version is released, the app will automatically render the relevant section of the changelog.