Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese translation and reorder LINGUAS in alphabetical order #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tuba2
Copy link

@Tuba2 Tuba2 commented Mar 18, 2024

This PR includes the following changes:

  1. Addition of a pt_BR.po file to the /po directory, containing a Brazilian Portuguese translation for the app, based on the latest PO file available in the repo;
  2. Edit to the LINGUAS file to include a "pt_BR" line, in order to make the Brazilian Portuguese translation available to the app;
  3. Reordering of the lines in the LINGUAS file in order to keep the language identifiers in alphabetical order.

Hope my work can be of use and help the app get more Brazilian Portuguese-speaking users. Thanks for the app!

Tuba2 added 2 commits March 17, 2024 20:57
Add pt_BR.po file containing a Brazilian Portuguese translation for the app, based on the latest POT file available in the repo.
Add a "pt_BR" line to the LINGUAS file and reorganize the file to keep the languages in alphabetical order.
@Tuba2
Copy link
Author

Tuba2 commented Mar 18, 2024

I should also add 2 things:

  1. I've considered @Luiz-C-Lima 's translation from Add Brazilian Portuguese Translation #118 when creating mine. I believe I've made it more consistent all around and also more accessible to Brazilian Portuguese-speakers with no knowledge of English. He can check my version and see if he agrees with my choices.
  2. The LINGUAS file does not include a "nl" line, even though the Dutch translation is already in the /po directory.

@Luiz-C-Lima
Copy link

I ask the maintainer to not accept either pull request yet, I believe that both translations have their own strengths, I will create a new translation with the better parts of both translations and send a pull request to @Tuba2 's repository with the updated translation and the reasoning of those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants