refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis?organizationId=TmV0ZmxpeCArIFNwcmluZw%3D%3D

Co-authored-by: Moderne <[email protected]>

src/main/java/org/springframework/data/ldap/repository/support/LdapRepositoryFactoryBean.java

@@ -40,7 +40,7 @@ public class LdapRepositoryFactoryBean<T extends Repository<S, Name>, S>
 		extends RepositoryFactoryBeanSupport<T, S, Name> {
 
 	private @Nullable LdapOperations ldapOperations;
-	private boolean mappingContextConfigured = false;
+	private boolean mappingContextConfigured;
 	private @Nullable MappingContext<? extends PersistentEntity<?, ?>, ? extends PersistentProperty<?>> mappingContext;
 
 	/**

src/test/java/org/springframework/data/ldap/repository/LdapRepositoryUnitTests.java

@@ -47,7 +47,8 @@ class LdapRepositoryUnitTests {
 
 	@Mock LdapOperations ldapOperations;
 
-	UnitTestPerson walter, hank;
+	UnitTestPerson walter;
+	UnitTestPerson hank;
 
 	PersonRepository repository;
 

src/test/java/org/springframework/data/ldap/repository/config/LdapRepositoryConfigurationExtensionUnitTests.java

@@ -41,12 +41,12 @@
  */
 class LdapRepositoryConfigurationExtensionUnitTests {
 
-	private StandardAnnotationMetadata metadata = new StandardAnnotationMetadata(Config.class, true);
-	private ResourceLoader loader = new PathMatchingResourcePatternResolver();
-	private Environment environment = new StandardEnvironment();
-	private BeanDefinitionRegistry registry = new DefaultListableBeanFactory();
+	private final StandardAnnotationMetadata metadata = new StandardAnnotationMetadata(Config.class, true);
+	private final ResourceLoader loader = new PathMatchingResourcePatternResolver();
+	private final Environment environment = new StandardEnvironment();
+	private final BeanDefinitionRegistry registry = new DefaultListableBeanFactory();
 
-	private RepositoryConfigurationSource configurationSource = new AnnotationRepositoryConfigurationSource(metadata,
+	private final RepositoryConfigurationSource configurationSource = new AnnotationRepositoryConfigurationSource(metadata,
 			EnableLdapRepositories.class, loader, environment, registry);
 
 	@Test // DATALDAP-60

src/test/java/org/springframework/data/ldap/repository/support/QPerson.java

@@ -35,7 +35,7 @@ public class QPerson extends EntityPathBase<UnitTestPerson> {
 
 	public final StringPath fullName = createString("fullName");
 
-	public final ListPath<String, StringPath> description = this.<String, StringPath> createList("description",
+	public final ListPath<String, StringPath> description = this. createList("description",
 			String.class, StringPath.class, PathInits.DIRECT2);
 
 	public final StringPath lastName = createString("lastName");

src/test/java/org/springframework/data/ldap/repository/support/QuerydslFilterGeneratorTests.java

@@ -30,9 +30,9 @@
  */
 class QuerydslFilterGeneratorTests {
 
-	private ObjectDirectoryMapper odm = new DefaultObjectDirectoryMapper();
-	private LdapSerializer tested = new LdapSerializer(odm, UnitTestPerson.class);
-	private QPerson person = QPerson.person;
+	private final ObjectDirectoryMapper odm = new DefaultObjectDirectoryMapper();
+	private final LdapSerializer tested = new LdapSerializer(odm, UnitTestPerson.class);
+	private final QPerson person = QPerson.person;
 
 	@Test
 	void testEqualsFilter() {

src/test/java/org/springframework/data/ldap/repository/support/QuerydslLdapPredicateExecutorUnitTests.java

@@ -53,7 +53,8 @@ class QuerydslLdapPredicateExecutorUnitTests {
 
 	@Mock LdapOperations ldapOperations;
 
-	UnitTestPerson walter, hank;
+	UnitTestPerson walter;
+	UnitTestPerson hank;
 
 	QuerydslLdapPredicateExecutor<UnitTestPerson> repository;