-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon reloading logic to only trigger for relevant file changes #258
Conversation
🦋 Changeset detectedLatest commit: 032f7d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@natemoo-re any chances this gets merged? It's pretty important. Thanks! |
Please merge this |
@stramel sorry to bother you, but this is important, as it makes the entire library unusable. Happy holidays! 🎈 |
Happy Holidays! Apologies for not getting to this before the holiday. I will work on getting this done in the next couple days. Hoping to have a release out before the new year. |
Thanks! |
Released in v1.1.5 |
@stramel thank you very much! |
Description:
This PR resolves #257, where unnecessary reloads are triggered when files in unrelated directories are modified (#251). It also fixes the issue where new files added to the
iconDir
directory do not trigger a reload due to the watcher only listening tochange
events.Changes:
iconDir
(specifically .svg files) or theastro.config
file triggers the reload event.Testing:
Before:
before.mov.out.mp4
After:
after.mov.out.mp4
Related PR: #251