Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization and bugfixes #20

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Modernization and bugfixes #20

wants to merge 12 commits into from

Conversation

tikonen
Copy link

@tikonen tikonen commented Jan 29, 2013

Original library doesn't seem to be maintained anymore, but here are my changes anyway as we use this fork in production.

  • internal zlib (from fork by @cweider) for dynamic content
  • internal zlib for staticGzip
  • uses modern 'send' npm module to send static data
  • fixes race condition in case multiple node instances access same files
  • re-enabled HEAD request and it should now work properly as lib uses 'send' module

@gcpantazis
Copy link

@nateps, +1 to merging this. We're using @tikonen's fork as well... resolved our issues with the current NPM build.

@tcbeutler
Copy link

@nateps +1 for merging this, also using @tikonen 's fork. Seems to be an issue with socket.io and gzip on Windows, getting "This socket is closed."

socketio/socket.io#932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants