Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for SciMLBase to 2, (keep existing compat) #246

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SciMLBase package from 1.90 to 1.90, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@nathanaelbosch nathanaelbosch force-pushed the compathelper/new_version/2023-09-23-01-05-50-798-01817550131 branch from 9b84b23 to 88ba730 Compare September 23, 2023 01:05
@ChrisRackauckas
Copy link
Contributor

This should be safe unless you have something with SDEs, then just make sure you check the constructor changes.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #246 (a25493c) into main (9a6699e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          33       33           
  Lines        1232     1232           
=======================================
  Hits         1179     1179           
  Misses         53       53           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nathanaelbosch nathanaelbosch force-pushed the compathelper/new_version/2023-09-23-01-05-50-798-01817550131 branch from 88ba730 to a25493c Compare October 4, 2023 07:43
@nathanaelbosch nathanaelbosch merged commit c515d34 into main Oct 4, 2023
7 checks passed
@nathanaelbosch nathanaelbosch deleted the compathelper/new_version/2023-09-23-01-05-50-798-01817550131 branch October 4, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants