-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolution
-> size
#19
Conversation
This commit works for me with Makie v0.20.9. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 4 4
Lines 41 41
=======================================
Hits 38 38
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Makie v0.20.0 deprecated the `resolution` argument, replacing it with `size` [1]. This causes Makie to emit deprecation warnings when a theme from TuePlots is loaded. Change that argument in TuePlots too. [1]: https://github.com/MakieOrg/Makie.jl/releases/tag/v0.20.0
I have rebased this to include the changes from other pull requests. I am moderately surprised that the tests don't fail in the downgrade job. Maybe this is because the tests don't actually attempt to generate any plots. |
Yes the package is not well-tested right now, so thanks for adding a small test. But with your small test this surprisingly looks fine, and so it should be good to go without any compat change? |
It really does seem to be running the tests with MakieCore v0.4.0:
So yes, probably good to go. I pushed a slightly clarified version of that test just now. |
Makie v0.20.0 deprecated the
resolution
argument, replacing it withsize
1. This causes Makie to emit deprecation warnings when a theme from TuePlots is loaded.Change that argument in TuePlots too.