Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolution -> size #19

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

musoke
Copy link
Contributor

@musoke musoke commented May 6, 2024

Makie v0.20.0 deprecated the resolution argument, replacing it with size 1. This causes Makie to emit deprecation warnings when a theme from TuePlots is loaded.

Change that argument in TuePlots too.

@musoke
Copy link
Contributor Author

musoke commented May 6, 2024

This commit works for me with Makie v0.20.9.
It is unclear what this does to backwards compatibility. Are there pre-0.20.0 versions of Makie that are compatible with this project and so will be broken by this change? If so, what is the correct change in the compat for MakieCore?

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (d2513e4) to head (e25c12e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files           4        4           
  Lines          41       41           
=======================================
  Hits           38       38           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makie v0.20.0 deprecated the `resolution` argument, replacing it
with `size` [1].  This causes Makie to emit deprecation warnings when a theme
from TuePlots is loaded.

Change that argument in TuePlots too.

[1]: https://github.com/MakieOrg/Makie.jl/releases/tag/v0.20.0
@musoke
Copy link
Contributor Author

musoke commented May 7, 2024

I have rebased this to include the changes from other pull requests.

I am moderately surprised that the tests don't fail in the downgrade job. Maybe this is because the tests don't actually attempt to generate any plots.

@nathanaelbosch
Copy link
Owner

Yes the package is not well-tested right now, so thanks for adding a small test. But with your small test this surprisingly looks fine, and so it should be good to go without any compat change?

@musoke
Copy link
Contributor Author

musoke commented May 7, 2024

It really does seem to be running the tests with MakieCore v0.4.0:

So yes, probably good to go.

I pushed a slightly clarified version of that test just now.

@nathanaelbosch nathanaelbosch merged commit e2a90b0 into nathanaelbosch:main May 7, 2024
7 checks passed
@musoke musoke deleted the resol-size branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants