Add Python linting #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanruiz
force-pushed
the
python-linting
branch
from
7cb7b79
to
e69a095
Compare
|
Download the artifacts for this pull request: |
The naming for "blur-compat" was misleading since the setting actually affects more than just blur affects. Additionally forwarding storage resolution but forcing an aspect ratio of 1.0 for the video is likely to result in odd rendering and there’s no known usecase for it. Both options control which video properties are exposed to libass so to fix the aforementioned issues merge these settings into one tri-state sub-ass-use-video-data. The default V keybind now cycles through all states of use-video-data instead of toggling vsfilter-aspect-compat. Resolves: mpv-player#10680
It is unclear whether there actually is any usecase for this option which isn't better served by sub-ass-use-video-data and/or LayoutRes overrides, but prior to the introduction of sub-ass-use-video-data it was possible to pass along storage resolution while faking an aspect ratio of 1:1. sub-ass-video-aspect-override=1 combined with sub-ass-use-video-data=all now makes this possible again. The uper limit of a 10:1 aspect matches the general video-aspect-override option.
These might be useful
This would cause us to exit out of the loop with a goto anytime we ran into XRUN or DRAINING and preparing PCM for use failed.
ALSA API reports -EPIPE even when the the device is lost, which we currently always assume to be an XRUN. If we assumed XRUN 10 times and didn't manage to recover, just consider the device lost and try to reconnect. Allows ao_alsa to recover from alsa server being killed then reinitialized. And even in the worst case, this should be better than the status quo of mpv attempting to prepare a PCM device indefinitely until the user restarts mpv. This is admittedly not ideal, and I don't think the -EPIPE hack is necessary anymore, but I can only test on my setup and removing the 'assume -EPIPE is an XRUN' hack might break some setups for whatever mysterious reasons.
Enabled the ruff python linter in CI, and resolved the issues that were detected by it.
nathanruiz
force-pushed
the
python-linting
branch
from
e69a095
to
4c0ca62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this before you submit this pull request:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md
Reading this link and following the rules will get your pull request reviewed
and merged faster. Nobody wants lazy pull requests.