Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved: NBN_GameClient_Start does not support domain name #28 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stemvork
Copy link
Contributor

In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead. Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.

In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead.
Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.
@stemvork
Copy link
Contributor Author

Interesting, that most tests succeed but 3 fail. I do not see how failing the emcc or webrtc soak tests is related to the code changed and could use some guidance on how to succesfully fix the issue.

@nathhB
Copy link
Owner

nathhB commented Sep 12, 2024

@stemvork the problem was indeed not related to your changes, it was an issue with emscripten version which I fixed in this commit: a33a169

regarding the PR, the change looks OK for resolving localhost but the idea behind the original issue was to resolve any domain name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants