Skip to content

Commit

Permalink
Merge pull request #171 from nationalarchives/docs/write-tests
Browse files Browse the repository at this point in the history
Recommend writing tests for the URL resolver
  • Loading branch information
dragon-dxw authored Jul 10, 2024
2 parents 037256e + fae6f1f commit e50c9a7
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions doc/adding-new-courts.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@

2. update [neutral_citation_regex.yaml](https://github.com/nationalarchives/ds-caselaw-utils/blob/main/src/ds_caselaw_utils/data/neutral_citation_regex.yaml) (utils)

3. add the URL chunks (courts, subcourts) to the [editor ui converters](https://github.com/nationalarchives/ds-caselaw-editor-ui/blob/main/judgments/converters.py)
3. add a test to [test_neutral.py]'s `good_neutral_urls` (https://github.com/nationalarchives/ds-caselaw-utils/blob/main/src/ds_caselaw_utils/test_neutral.py) (utils), test with `poetry run pytest`

4. add the URL chunks (courts, subcourts) to the [public ui converters](https://github.com/nationalarchives/ds-caselaw-public-ui/blob/main/judgments/converters.py)
4. add the URL chunks (courts, subcourts) to the [editor ui judgments/converters.py](https://github.com/nationalarchives/ds-caselaw-editor-ui/blob/main/judgments/converters.py)

5. deploy all the things (utils, editor, public), not forgetting to bump
5. add the URL chunks (courts, subcourts) to the [public ui judgments/converters.py](https://github.com/nationalarchives/ds-caselaw-public-ui/blob/main/judgments/converters.py)

6. deploy all the things (utils, editor, public), not forgetting to bump
the version of utils in all those things.

#### if you're adding a new name for an old court
Expand Down

0 comments on commit e50c9a7

Please sign in to comment.