Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCL-176] Tooling configuration audit #168

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

jacksonj04
Copy link
Collaborator

@jacksonj04 jacksonj04 commented Jun 27, 2024

A series of commits which together make all of FCL's repositories behave more consistently with regard to tooling.

Jira

FCL-176

What?

  • .pre-commit-config.yaml does not exclude directories which don't exist, doesn't set default hooks where they aren't needed, and doesn't specify auto-update behaviour
  • The pre-commit-hooks repo includes the new, broader set of recommended checks
  • Python formatting is done using ruff
  • Python linting is done using ruff
  • detect-secrets is removed (deprecated in favour of GitHub's more comprehensive approach)
  • prettier config has been harmonised

@jacksonj04 jacksonj04 changed the title [FCL-176] Pre-commit audit [FCL-176] Tooling configuration audit Jul 1, 2024
@jacksonj04 jacksonj04 force-pushed the FCL-176-pre-commit-audit branch from 740a9cf to 98c9cf2 Compare July 1, 2024 11:07
@jacksonj04 jacksonj04 marked this pull request as ready for review July 2, 2024 12:00
@jacksonj04 jacksonj04 requested a review from dragon-dxw July 2, 2024 12:01
@jacksonj04 jacksonj04 enabled auto-merge July 2, 2024 15:37
Pre-commit gives us a set of high-level hooks which rapidly sense-check aspects of the repository. This commit adds new ones for preventing the addition of large files, checking for filename casing conflicts, preventing committing of files with open merge conflicts, checking XML validity, preventing the addition of submodules, warning when files have mixed line endings, and accidentally committing to `main`. It also reorders this list for clarity.
@jacksonj04 jacksonj04 force-pushed the FCL-176-pre-commit-audit branch from 078d67c to bbe319c Compare July 2, 2024 15:38
@jacksonj04 jacksonj04 merged commit 4abdd77 into main Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants