FIND-75 Nunjucks variant #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahosgood
reviewed
Jan 17, 2025
ahosgood
reviewed
Jan 17, 2025
ahosgood
reviewed
Jan 17, 2025
ahosgood
reviewed
Jan 17, 2025
ahosgood
reviewed
Jan 17, 2025
ahosgood
reviewed
Jan 17, 2025
…nalarchives/ds-search into feature/FIND-75-nj-variant # Conflicts: # poetry.lock
…riant' of https://github.com/nationalarchives/ds-search into feature/FIND-75-nj-variant Moving side filters to an include folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Ticket URL: https://national-archives.atlassian.net/jira/software/c/projects/FIND/issues/FIND-75
About these changes
Refactored the code to use nunjucks.
The accordion / side filters are now called in as an include 'accord.html'
How to check these changes
Run branch locally
Check functionality
Check layout
Before assigning to reviewer, please make sure you have