User is informed their metadata upload has failed #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail type 1: Selected a file other than a CSV
The
input[type=file]element has an 'accept' param in which you can specify a mime type ("text/csv") and this prevents anything other than a CSV from being selected. This may negate the need for an extension check using JS and therefore an error on the upload page itself.Fail type 2: After CSV has been uploaded - Virus or checksum
After the file has hit the server and we've found a virus or a checksum error. A page shows whilst the server-side processing happens and when prompted the user navigates to a results page with fail information.