Add series to metadata review request event (#4084)

Add seriesCode to `MetadataReviewRequestEvent`
nationalarchives · Aug 12, 2024 · e63ff23 · e63ff23
1 parent 9310c01
commit e63ff23
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/app/controllers/RequestMetadataReviewController.scala b/app/controllers/RequestMetadataReviewController.scala
@@ -52,6 +52,7 @@ class RequestMetadataReviewController @Inject() (
           transferringBodyName = summary.transferringBodyName,
           consignmentReference = summary.consignmentReference,
           consignmentId = consignmentId.toString,
+          seriesCode = summary.seriesName,
           userId = request.token.userId.toString,
           userEmail = request.token.email
         )

diff --git a/app/services/MessagingService.scala b/app/services/MessagingService.scala
@@ -47,6 +47,7 @@ object MessagingService {
       transferringBodyName: Option[String],
       consignmentReference: String,
       consignmentId: String,
+      seriesCode: Option[String],
       userId: String,
       userEmail: String
   )

diff --git a/test/controllers/RequestMetadataReviewControllerSpec.scala b/test/controllers/RequestMetadataReviewControllerSpec.scala
@@ -101,7 +101,7 @@ class RequestMetadataReviewControllerSpec extends FrontEndTestHelper {
 
     "add status, send metadata review request notification and render the metadata review page" in {
       setConsignmentTypeResponse(wiremockServer, "standard")
-      setConsignmentSummaryResponse(wiremockServer, transferringBodyName = "Mock".some, consignmentReference = "TDR-2024")
+      setConsignmentSummaryResponse(wiremockServer, transferringBodyName = "Mock".some, consignmentReference = "TDR-2024", seriesName = "someSeries".some)
       setConsignmentStatusResponse(app.configuration, wiremockServer)
       setAddConsignmentStatusResponse(wiremockServer)
       setUpdateConsignmentStatus(wiremockServer)
@@ -114,7 +114,8 @@ class RequestMetadataReviewControllerSpec extends FrontEndTestHelper {
       playStatus(content) mustBe SEE_OTHER
       redirectLocation(content).get must equal(s"/consignment/$consignmentId/metadata-review/review-progress")
 
-      val metadataReviewRequestEvent = MetadataReviewRequestEvent("Mock".some, "TDR-2024", consignmentId.toString, "c140d49c-93d0-4345-8d71-c97ff28b947e", "[email protected]")
+      val metadataReviewRequestEvent =
+        MetadataReviewRequestEvent("Mock".some, "TDR-2024", consignmentId.toString, "someSeries".some, "c140d49c-93d0-4345-8d71-c97ff28b947e", "[email protected]")
       verify(messagingService, times(1)).sendMetadataReviewRequestNotification(metadataReviewRequestEvent)
     }
 

diff --git a/test/services/MessagingServiceSpec.scala b/test/services/MessagingServiceSpec.scala
@@ -47,13 +47,15 @@ class MessagingServiceSpec extends AnyFlatSpec with Matchers {
       transferringBodyName = Some("TransferringBodyName"),
       consignmentReference = "Ref123",
       consignmentId = "ConsID456",
+      seriesCode = Some("SomeSeries"),
       userId = "UserID789",
       userEmail = "[email protected]"
     )
     val expectedMessageString = """{
                                   |  "transferringBodyName" : "TransferringBodyName",
                                   |  "consignmentReference" : "Ref123",
                                   |  "consignmentId" : "ConsID456",
+                                  |  "seriesCode" : "SomeSeries",
                                   |  "userId" : "UserID789",
                                   |  "userEmail" : "[email protected]"
                                   |}""".stripMargin