Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation to generate_ll_from_utm #108

Merged
merged 5 commits into from
Jun 27, 2024
Merged

add documentation to generate_ll_from_utm #108

merged 5 commits into from
Jun 27, 2024

Conversation

wright13
Copy link
Collaborator

@wright13 wright13 commented Jun 3, 2024

Just an addition to the documentation explaining how to pass in variables that are storing column names. I don't remember if I need to manually rebuild the gh pages site or if it'll do it automatically on merge - happy to rebuild on my end if needed.

@wright13 wright13 requested a review from RobLBaker June 3, 2024 22:59
@RobLBaker
Copy link
Member

Sounds good. I can take care of building the web pages, etc if needed, but I have some deadlines and travel coming up probably won't get around to merging this in until June 24 or after.

@wright13
Copy link
Collaborator Author

wright13 commented Jun 4, 2024

Added the removeEmptyTables function to this PR and rebuilt pkgdown pages. No rush on merging but let me know if there's anything I can do on my end to make it easier.

Copy link
Member

@RobLBaker RobLBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; can you update the removeEmptyTables function to be consistent with the naming scheme of the other functions in the package (e.g. "remove_empty_tables")

Copy link
Member

@RobLBaker RobLBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

@RobLBaker RobLBaker merged commit 33ad267 into master Jun 27, 2024
7 checks passed
@RobLBaker RobLBaker deleted the sarah-dev branch June 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants