Fix stream snapshot error messaging #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
MauriceVanVeen
force-pushed
the
fix/stream-snapshot-error-messaging
branch
from
ff201f1 to
7a8d8e3
Compare
|
@MauriceVanVeen hmm, I totally forgot about this one, is it still good to merge? |
|
@ripienaar, yep good to merge, but it's awaiting the server PR: nats-io/nats-server#5873 |
|
@ripienaar, the server PR has been merged, this one is now also good to go 👍 |
|
Thank you @MauriceVanVeen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#545 introduced checking if during a stream snapshot there was some sort of error.
However
Nats-Request-Infowas checked which doesn't seem to contain this info.The server reports the header
NATS/1.0 408 No Interestwhich is reflected in the headers as:{Status: "408", Description: "No Interest"}.Source for reference: https://github.com/nats-io/nats-server/blob/a07bde9fa7d499c7039f74cac9d11f4c046b9250/server/jetstream_api.go#L3826
This PR fixes using the correct header, and also only calling
cancel()after we've added the error to theerrcas otherwise the error would not be logged.